Wireshark · Ethereal-dev: Re: [Ethereal-dev] Patch to bring packet-iscsi.c in line with protocol version 08

[Guy Harris <guy@xxxxxxxxxx>]

> The enclosed patch brings packet-iscsi.c into line with version 08 of
> the iSCSI protocol.

Checked in.

> Please report any bugs/suggestions to me.

Suggestions:

	1) make the heuristics stronger, so that it's less likely to
	   identify non-iSCSI packets as iSCSI (that's a bit of a
	   problem now);

	2) add support for TCP reassembly - at least as I read the spec,
	   the TotalAHSLength and DataSegmentLength fields in the Basic
	   Header Segment should tell you how large the entire PDU is
	   (other than the header and data digests).

Note that the dissector should also be made to handle multiple iSCSI
PDUs in one TCP segment, if it doesn't do so already....