Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-users: [Wireshark-users] bug on packet-gsm_sms.c short buffer

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: "david ceccanti" <david.ceccanti@xxxxxxxxxxxxx>
Date: Tue, 10 Jun 2008 11:39:23 +0200

Probably there is a short buffer in :

 

static void

dis_field_ud(tvbuff_t *tvb, proto_tree *tree, guint32 offset, guint32 length, gboolean udhi, guint8 udl,

    gboolean seven_bit, gboolean eight_bit, gboolean ucs2, gboolean compressed)

{

    static guint8  fill_bits_mask[NUM_FILL_BITS_MASKS] =

            { 0x80, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc };

    proto_item    *item;

    proto_item    *udh_item;

    proto_tree     *subtree = NULL;

    proto_tree     *udh_subtree = NULL;

    guint8           oct;

    guint fill_bits;

    guint32         out_len;

    char  *ustr;

    char        messagebuf[160];

 

Because when messsage is or more than 160 wireshark crashes.

 

Please may you review it.

 

Cecco

 

  • Follow-Ups:
    • Re: [Wireshark-users] bug on packet-gsm_sms.c short buffer
      • From: Jaap Keuter
  • Prev by Date: Re: [Wireshark-users] I can not see any significant data with RTP Player
  • Next by Date: Re: [Wireshark-users] What is a good average for malformed packets
  • Previous by thread: Re: [Wireshark-users] I can not see any significant data with RTP Player
  • Next by thread: Re: [Wireshark-users] bug on packet-gsm_sms.c short buffer
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation