Wireshark · Wireshark-dev: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add

Wireshark-dev: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item(

From: Guy Harris <guy@xxxxxxxxxxxx>

Date: Mon, 10 Oct 2011 11:58:59 -0700

On Oct 10, 2011, at 11:44 AM, Bill Meier wrote:

> In any case, no matter what is decided, changes will be needed for FT_STRING & etc.
> 
> Is it OK to just change all the instances with no character encoding to ENC_ASCII (with or without ENC_NA) ?

That, or ENC_UTF_8.  I suspect most new protocols support UTF-8; older ones either only specify ASCII or use various legacy encodings.  Automated replacement will get it wrong for some protocols regardless of whether we use ENC_ASCII or ENC_UTF_8; the question is which of those would be worse, for some value of "worse".

References:
- [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
  - From: Bill Meier
- Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
  - From: Guy Harris
- Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
  - From: Bill Meier

Prev by Date: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
Next by Date: Re: [Wireshark-dev] [Wireshark-commits] rev 39328: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acn.c packet-ancp.c packet-ansi_a.c packet-aodv.c packet-aruba-papi.c packet-asap.c packet-assa_r3.c ...
Previous by thread: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
Next by thread: Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
Index(es):
- Date
- Thread