Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38345: /trunk/ /trunk/: CMakeLists.txt /trunk/wsutil/: C

[Joerg Mayer <jmayer@xxxxxxxxx>]

On Fri, Aug 05, 2011 at 02:45:09AM +0200, Joerg Mayer wrote:
> > Directory: /trunk/wsutil/
> >   Changes    Path              Action
> >   +1 -1      CMakeLists.txt    Modified
> 
> GLIB2_LIBRARIES -> GLIB2_LDFLAGS
> 
> Is this really the correct place or should this be fixed in FindGLIB2 instead?

>From /usr/share/cmake/Modules/readme.txt:

XXX_LIBRARIES           The libraries to link against to use XXX. These should include full paths.  This should not be a cache entry.

So we'll need to fix the FindGLIB2.cmake as the proper fix.

ciao
     Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.