Den 22. aug. 2007 kl. 14.43 skrev martinm@xxxxxxxxxxxxx:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22586
User: martinm
Date: 2007/08/22 02:43 PM
Log:
Show which bits 'fragment offset' comes from (I had to look it up :
( )
My personal opinion is that this bitfields should be hidden in a
subtree, like this patch:
- proto_tree_add_uint(ip_tree, hf_ip_frag_offset, tvb, offset + 6, 2,
- (iph->ip_off & IP_OFFSET)*8);
+ tf = proto_tree_add_uint_format(ip_tree, hf_ip_frag_offset, tvb,
offset + 6, 2,
+ iph->ip_off, "Fragment offset: %d", (iph->ip_off & IP_OFFSET)*8);
+ field_tree = proto_item_add_subtree(tf, ett_ip_frag_offset);
+ proto_tree_add_item(field_tree, hf_ip_frag_offset, tvb, offset +
6, 2, FALSE);
Any opinions before I submit my patch?
--
Stig Bjørlykke
