Wireshark-dev: Re: [Wireshark-dev] [PATCH]: New packet disscetor for IEEE1588v2 / PTPv2

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 06 Jul 2007 09:53:18 -0700

Anders Broman wrote:

I will appliy the ETHERTYPES patch but can you please change the other patch
to not do:
- * Wireshark - Network traffic analyzer
- * By Gerald Combs <gerald@xxxxxxxxxxxxx>
+ * Ethereal - Network traffic analyzer
+ * By Gerald Combs <gerald@xxxxxxxxxxxx>
There is also another instance of "Ethereal" that should be changed.

Yes - it's been Wireshark for a while.

The names comes out strange on my computer
- * Copyright 2004, Dominic Béchaz <bdo@xxxxxxxx> , ZHW/InES
+ * Copyright 2004, Dominic B�chaz <bdo@xxxxxxxx> , ZHW/InES
  * Copyright 2004, Markus Seehofer <mseehofe@xxxxxxxxxxxxxxxx>
+ * Copyright 2006, Christian Sch�r <scc@xxxxxxxx>
+ * Copyright 2007, Markus Renz <Markus.Renz@xxxxxxxxxxxxx>
Might be changed to.

Non-ASCII characters run the risk of not looking correct on all systems. If they're encoded in UTF-8, they might not look right on systems not using UTF-8; even as UTF-8 becomes more common, there's the issue of precomposed characters (used by most OSes) vs. decomposed characters (used by OS X) - OS X probably displays precomposed characters correctly, even if it might make it harder to insert them, but I suspect some other platforms won't display decomposed characters correctly (for example, Wireshark, using GTK+'s file dialog, doesn't correctly display file names with decomposed characters - even on OS X).