ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21831: /trunk/ /trunk/epan/dissector

From: "Burlyga, Alex" <Alex.Burlyga@xxxxxxxxxx>
Date: Fri, 18 May 2007 23:50:07 -0700
Mine compilation breaks with a different errors:
cc1: warnings being treated as errors
capture_if_dlg.c: In function 'capture_if_cb':
capture_if_dlg.c:459: warning: passing argument 2 of 'g_list_sort' from
incompatible pointer type
capture_if_dlg.c:476:66: error: "/*" within comment
make[2]: *** [capture_if_dlg.o] Error 1
make[2]: Leaving directory `/home/kirpich/src/wireshark/gtk'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kirpich/src/wireshark'
make: *** [all] Error 2

Looks like it does not like nested comments as well as newly introduced
g_list_sort call.

Alex. 

> -----Original Message-----
> From: Gerald Combs [mailto:gerald@xxxxxxxxxxxxx] 
> Sent: Friday, May 18, 2007 5:08 PM
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 21831: 
> /trunk/ /trunk/epan/dissectors/: Makefile.nmake 
> packet-ieee80211.c packet-ieee80211.h packet-radiotap.c 
> /trunk/gtk/: Makefile.nmake airpcap_dlg.c airpcap_dlg.h 
> airpcap_gui_utils.c /trunk/: ...
> 
> We're working on a fix.  Sorry for any inconvenience.
> 
> Stephen Fisher wrote:
> > I'm getting compilation errors on a Windows box with 
> AirPcap installed 
> > since I did an svn update.  I assume it's related to the 
> check-in at 
> > the bottom of this e-mail.  The errors start with:
> > 
> > C:\wireshark\airpcap_loader.h(84) : error C2146: syntax error : 
> > missing ')' before identifier 'ChannelInfo'
> > C:\wireshark\airpcap_loader.h(84) : error C2081: 
> 'AirpcapChannelInfo' : 
> > name in formal parameter list illegal
> > C:\wireshark\airpcap_loader.h(84) : error C2061: syntax error : 
> > identifier 'ChannelInfo'
> > C:\wireshark\airpcap_loader.h(84) : error C2059: syntax error : ';'
> > C:\wireshark\airpcap_loader.h(84) : error C2059: syntax error : ')'
> > C:\wireshark\airpcap_loader.h(85) : error C2146: syntax error : 
> > missing ')' before identifier 'PChannelInfo'
> > C:\wireshark\airpcap_loader.h(85) : error C2081: 
> 'PAirpcapChannelInfo' : 
> > name in formal parameter list illegal
> > 
> > And so on for a total of 92 errors ;)
> > 
> > On Fri, May 18, 2007 at 09:06:26PM +0000, 
> gerald@xxxxxxxxxxxxx wrote:
> >> 
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=2183
> >> 1
> >>
> >> User: gerald
> >> Date: 2007/05/18 09:06 PM
> >>
> >> Log:
> >>  From Dustin Johnson:
> >>  
> >>    - Update the wireless/AirPcap GUI code to support 
> 802.11n as well as
> >>      some related upcoming code changes.
> >>    - Remove airpcap.h from the repository, since it exists 
> in the AirPcap
> >>      devpack (and will be superseded Real Soon Now).
> >>    - Show the individual channel flag bits in radiotap.
> >>    
> >>  Fix the 802.11n MCS set display.
> >>  
> >>  This is a partial checkin, so hopefully nothing is broken.
> >>
> >> Directory: /trunk/epan/dissectors/
> >>   Changes    Path                  Action
> >>   +1 -1      Makefile.nmake        Modified
> >>   +8 -8      packet-ieee80211.c    Modified
> >>   +1 -0      packet-ieee80211.h    Modified
> >>   +60 -4     packet-radiotap.c     Modified
> >>
> >> Directory: /trunk/gtk/
> >>   Changes    Path                   Action
> >>   +1 -1      Makefile.nmake         Modified
> >>   +115 -257  airpcap_dlg.c          Modified
> >>   +0 -29     airpcap_dlg.h          Modified
> >>   +311 -129  airpcap_gui_utils.c    Modified
> >>   +31 -3     airpcap_gui_utils.h    Modified
> >>   +6 -2      capture_dlg.c          Modified
> >>   +17 -3     capture_if_dlg.c       Modified
> >>
> >>
> >> (8 files not shown)
> >> _______________________________________________
> >> Wireshark-commits mailing list
> >> Wireshark-commits@xxxxxxxxxxxxx
> >> http://www.wireshark.org/mailman/listinfo/wireshark-commits
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> 
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>