Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] [PATCH] New menu items to copy packet data

From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Sat, 27 Jan 2007 18:54:18 -0800
On Thu, Jan 11, 2007 at 01:59:56PM -0000, Douglas Pratley wrote:

> This is a patch adding items to the context menus for the packet list 
> and packet details panes for copying packet data to the clipboard.

I've checked in your changes as SVN revision 20581.  Thanks for your 
contribution!  I'll check in your documentation changes next.  I did 
make the following changes:

 - Removed base64 encoding support as we discussed.  This leaves room 
for a base64 decoder as a future feature.

 - moved eth_clist_get_text define up higher in the list of defines to 
keep it alphabetically sorted (packet_list.c)

 - took out the empty gtk1 copy_binary_to_clipboard function and wrapped 
its declaration in the header file and case(CD_BINARY) in #if 
GTK_MAJOR_VERSION >= 2 (gui_utils.c / gui_utils.h)

 - wrapped create_copy_binary_t and destroy_copy_binary_t within the 
same #if GTK_MAJOR_VERSION >= 2 since those functions aren't used in 
GTK1

 - took extra new line break out of end of proto_draw.h

 - changed all calls to g_string_append_printf to g_string_sprintfa for 
GTK1 compatibility

 - changed call to g_ascii_isprint to isprint for GTK1 compatibility 
(proto_draw.c)

 - changed call to g_string_append_len to g_string_append for GTK1 
compatability since it was appending the entire string anyway 
(proto_draw.c)


Thanks,
  Steve