Hi,
Le jeudi 16 novembre 2006 ￜ 10:36 +0100, Jaap Keuter a ￜcrit :
> Hi,
>
> This is a patch for AppleTalk, at least to make one of my captures with
> ZIP (GetNetInfo request) to work. Current dissector misses the Zone
> UINT_STRING by one. At least I assume that it's the Zone string, could be
> an additional string as well.
>
Doesn't seem right.
>From where these packets are coming? Small capture?
> Index: packet-atalk.c
> ===================================================================
> --- packet-atalk.c (revision 19908)
> +++ packet-atalk.c (working copy)
> @@ -1633,8 +1633,8 @@
> break;
>
> case 5 : /* GetNetInfo request */
> - proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 1, FALSE);
> - offset++;
> + proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 2, FALSE);
> + offset += 2;
> proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 4, FALSE);
> offset += 4;
> proto_tree_add_item(zip_tree, hf_zip_zone_name, tvb, offset, 1,FALSE);
>
> Anyone knowledgeable about AppleTalk wish to give their insight?
>
> Thanx,
> Jaap
>
Didier
