Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-dev: Re: [Wireshark-dev] patch to eyesdn wiretap module

From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Wed, 27 Sep 2006 22:44:19 +0200 (CEST)
Hi,

Why not adding 129 as allowed channel number?
Please supply patch as attachment for easy handling.

Thanx,
Jaap

On Wed, 27 Sep 2006, Rolf Fiedler wrote:

> Hi,
>
> I am the author of the eyesdn wiretap module. Recently we added ATM
> support to our trace format. We used channel id 129 for that, so far
> only 0 for D channel and 1-30 for bearer channels had been in use.
>
> The current EyeSDN wiretap has a sanity check and does not accept
> channel numbers larger than 30. I removed this check, since it is
> pointless and now prevents us from importing our ATM traces.
>
> I created a patch to wiretap/eyesdn.c, can somebody with svn write
> permission please apply it? This patch will not harm anybody, it simply
> removes a check and allows ATM traces to be read. Only applies to users
> of the innoventif EyeSDN USB probes.
>
> Thanks a lot,
> Rolf
>
> rfie@p4ht3g:~/src/wireshark$ svn diff
> Index: wiretap/eyesdn.c
> ===================================================================
> --- wiretap/eyesdn.c    (Revision 19336)
> +++ wiretap/eyesdn.c    (Arbeitskopie)
> @@ -260,13 +260,6 @@
>          pkt_len = (pkt_len << 8) | ((unsigned long) hdr[11]);
>
>          /* sanity checks */
> -        if(channel>30) {
> -           *err = WTAP_ERR_BAD_RECORD;
> -            *err_info = g_strdup_printf("eyesdn: bad channel number %u",
> -               channel);
> -           return -1;
> -       }
> -
>          if(direction>1) {
>             *err = WTAP_ERR_BAD_RECORD;
>              *err_info = g_strdup_printf("eyesdn: bad direction value %u",
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
>