ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] rev 34141: /trunk/ /trunk/epan/dissectors/: packet-nfs.c pac

Date: Fri, 17 Sep 2010 02:03:13 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=34141

User: morriss
Date: 2010/09/16 07:03 PM

Log:
 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5197 :
 
 The NFS dissector (all versions) show access types that have not been requested
 to be checked as "not allowed" in the call and reply.  This is incorrect and
 misleading.  At present one must manually compare what was requested in order
 to assess if access was actually denied for that type.  When there are hundreds
 or thousands of these ACCESS requests in a capture, it is not possible or
 practical to manually check each one.  
 
 The submitted patch does the following:
 
 * Passes the access mask in the call to the reply for comparison
 * Adds filterable fields for each supported (v4) and access type
 * Adds a pseudo field, nfs.access_denied
 * Lists the access types to be checked in the summary and tree
 * Separately lists the supported, denied, and allowed access types in the 
   summary and tree
 
 The changes are applied to all NFS versions.
 
 
 From me: a couple of small changes to make it compile without warnings.

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +360 -69   packet-nfs.c       Modified
  +13 -2     packet-nfs.h       Modified
  +13 -2     packet-nfsacl.c    Modified

Directory: /trunk/
  Changes    Path          Action
  +4 -1      AUTHORS       Modified