Wireshark

  • Riverbed Technology
  • WinPcap
the world's foremost network protocol analyzer
  • Wireshark
    • About
    • Download
    • Blog
  • Get Help
    • Ask a Question
    • FAQs
    • Documentation
    • Mailing Lists
    • Online Tools
    • Wiki
    • Bug Tracker
  • Develop
    • Get Involved
    • Developer's Guide
    • Browse the Code
    • Latest Builds

Wireshark-commits: [Wireshark-commits] rev 28270: /trunk/gtk/ /trunk/gtk/: expert_comp_dlg.c

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next


From: guy@xxxxxxxxxxxxx
Date: Tue, 05 May 2009 00:36:00 GMT

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28270

User: guy
Date: 2009/05/04 05:36 PM

Log:
 The reason why the expert_item value is null when performing a retap is
 that a retap doesn't build the protocol tree unless there's a tap with a
 filter; presumably "the expert_item value" refers to the item to which
 expert information is being attached.
 
 However, if there's no protocol item, the only thing
 expert_add_info_format() doesn't do is set the severity and group for a
 protocol item, but the expert info composite dialog doesn't appear to
 look at that.
 
 Thus, it appears we can just use cf_retap_packets(); do so, as it's
 faster.

Directory: /trunk/gtk/
  Changes    Path                 Action
  +17 -15    expert_comp_dlg.c    Modified


  • Prev by Date: [Wireshark-commits] rev 28269: /trunk/gtk/ /trunk/gtk/: airpcap_dlg.c decode_as_dlg.c main.c main.h main_menu.c main_packet_list.c prefs_dlg.c proto_dlg.c
  • Next by Date: [Wireshark-commits] rev 28271: /trunk/epan/ /trunk/epan/: plugins.c
  • Previous by thread: [Wireshark-commits] rev 28269: /trunk/gtk/ /trunk/gtk/: airpcap_dlg.c decode_as_dlg.c main.c main.h main_menu.c main_packet_list.c prefs_dlg.c proto_dlg.c
  • Next by thread: [Wireshark-commits] rev 28271: /trunk/epan/ /trunk/epan/: plugins.c
  • Index(es):
    • Date
    • Thread

Wireshark and the "fin" logo are registered trademarks of the Wireshark Foundation