Wireshark-commits: [Wireshark-commits] rev 22770: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pppoe.c

From: guy@xxxxxxxxxxxxx
Date: Sun, 02 Sep 2007 22:49:57 GMT

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22770

User: guy
Date: 2007/09/02 10:49 PM

Log:
 The actual length of the PPPoE payload is returned by
 tvb_reported_length_remaining(), not by tvb_length_remaining() -
 tvb_length_remaining() shows only the amount of *captured* data
 remaining, but the capture might have been done with a snapshot length
 that cut the packet data short.
 
 The payload length from the PPPoE header could legitimately be different
 from the actual length of the PPPoE payload if there's not enough PPPoE
 payload to avoid padding at the E(thernet) level.  Only complain if
 there shouldn't have been any padding.
 
 Report an "expert" warning if the payload length looks wrong.
 
 Update a comment to reflect current reality (as of many many years ago,
 when we went all-tvbuff).

Directory: /trunk/epan/dissectors/
  Changes    Path              Action
  +27 -9     packet-pppoe.c    Modified