Wireshark-commits: [Wireshark-commits] rev 20714: /trunk/epan/ /trunk/epan/: strutil.c

From: sfisher@xxxxxxxxxxxxx
Date: Sun, 04 Feb 2007 19:23:11 GMT

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20714

User: sfisher
Date: 2007/02/04 07:23 PM

Log:
 From Sebastien Tandel:
 
    Steve has modified a while ago hex_str_to_bytes to handle Cisco MAC
 format (xxxx.xxxx.xxxx). It did not test the nullity of the third and
 fourth byte (*r, *s) which is however done for the second byte. The test
 on the second byte is done as well in the following conditional tests.
 If this test is not mandatory thanks to the return value of isxdigit (at
 least on GNU/Linux and guess it should be the same on any platform), it
 would be better to follow the same logic in all tests cases for the
 comprehension of everyone (... which /could/ even, with luck, be turned
 in a faster code).
 Here is a light patch to follow the logic of the conditional tests done
 in the function.

Directory: /trunk/epan/
  Changes    Path          Action
  +2 -1      strutil.c     Modified