Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 7348] When listing protocols available for "Decode As", pl

Date: Wed, 29 Aug 2012 12:01:43 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7348

--- Comment #8 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-08-29 12:01:43 PDT ---
(In reply to comment #7)
> Created attachment 9006 [details]
> Sort dissectors patch v2

Sorting looks good!

In dissector_compare_filter_name(), why not just use "" instead of "(none)"?

Any possibility of removing the duplicates mentioned in comment 5?

> Hopefully this takes care of all of the sorting issues.  It's not fast with the
> sorting of the hash table keys and then using the keys to look back into the
> hash table, but the function shouldn't be used that much that speed should
> really be an issue.

In my simple tests, it did not appear any slower, so I don't think there should
be any concern about performance here.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.