https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881
--- Comment #12 from FF <francesco.fondelli@xxxxxxxxx> 2012-07-28 07:44:55 PDT ---
(In reply to comment #11)
> FF:
>
> I suspect the following in mpls_pm_build_cinfo:
> } else {
> <...>
> *sid = ((guint32) sid0 >> 6) | ((guint32) sid1 >> 8) |
> ((guint32) sid2 >> 16) | ((guint32) sid3 >> 24);
> }
>
>
> should be corrected to be:
>
> } else {
> <...>
> *sid = ((guint32) sid0 >> 6) | ((guint32) sid1 << 8) |
> ((guint32) sid2 << 16) | ((guint32) sid3 << 24);
> }
>
>
> If so, I'll commit the correction ....
>
> Thanks
Hi Bill,
sure, you are right (grrr I tested this with sid = 1, 2 and 3). Would you
mind to also remove those ugly spaces between types and variables, I
mean:
} else {
<...>
*sid = ((guint32)sid0 >> 6) | ((guint32)sid1 << 8) |
((guint32)sid2 << 16) | ((guint32)sid3 << 24);
}
thanks a lot!
ciao
FF
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
