https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4997
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4928|review_for_checkin? |review_for_checkin-
Flags| |
--- Comment #8 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-07-22 18:44:48 PDT ---
Comment on attachment 4928
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4928
SSTP dissector
Some initial comments:
1. To ensure this "plays nicely" with HTTPS on port 443, should the SSL port be
a "preference" (0 for disabled by default). Maybe even a "heuristic"
dissector?
2. No preferences are given, yet prefs_register_protocol is used.
3. Patch should include modified makefiles to build packet-sstp.c
4. Run checkhf.pl
5. "Conversation" refered to by Jaap in comment 6, was geared as using the
"conversation API" of wireshark (see README.developer section 2.1). There
shouldn't be a global variable to control this, especially if you could have
multiple or mixed conversations.
6. Per http://msdn.microsoft.com/en-us/library/cc247338(PROT.10).aspx noted in
the dissector comments, it appears the specification has changed drastically.
How adaptable is this currect dissector to the latest spec?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
