Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 7154] patch: dissector for ISIS-SPB MT-Port-Cap TLV and su

Date: Mon, 23 Apr 2012 01:30:36 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7154

--- Comment #7 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-04-23 01:30:36 PDT ---
(In reply to comment #6)
> (In reply to comment #2)
> > Hi,
> > 
> > It is not possible to use proto_tree_add_item ? (it is not recommended to use
> > proto_tree_add_text...)
> 
> Thanks for the feedback.  As a wireshark newbie, I wasn't aware of the
> preference for proto_tree_add_item.  In packet-isis-*.c, proto_tree_add_text
> appears to be called far more often than proto_tree_add_item, so I just
> followed the convention that seemed to be preferred based on what I saw in
> those files.

Yes, it is better to use the some convention but use proto_tree_add_item is
better ! (Make field filterable...)

It is possible to update your patch ?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.