https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7142
Summary: Permit hints in DISSECTOR_ASSERT calls
Product: Wireshark
Version: SVN
Platform: All
OS/Version: All
Status: NEW
Severity: Minor
Priority: Low
Component: Wireshark
AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
ReportedBy: eapache@xxxxxxxxx
Build Information:
wireshark 1.7.2 (SVN Rev Unknown from unknown)
Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.10.2, with Pango 1.30.0, with
GLib 2.32.1, with libpcap, with libz 1.2.3.4, with POSIX capabilities (Linux),
with SMI 0.4.8, with c-ares 1.7.5, with Lua 5.1, without Python, with GnuTLS
2.12.14, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with PortAudio
V19-devel (built Dec 10 2011 11:43:10), with AirPcap.
Running on Linux 3.2.0-23-generic, with locale en_CA.UTF-8, with libpcap
version
1.1.1, with libz 1.2.3.4, GnuTLS 2.12.14, Gcrypt 1.5.0, without AirPcap.
Built using gcc 4.6.3.
--
There are currently many pieces of code which AND string constants into their
DISSECTOR_ASSERT() conditions in order to provide a hint to whoever ends up
seeing the assertion. There's nothing technically wrong with this (since string
constants are always true), but it's not nice from a style perspective.
The first patch adds a DISSECTOR_ASSERT_HINT() macro which is exactly like
DISSECTOR_ASSERT() except that it takes an extra hint parameter. The second
patch converts a few instances in conversation.c, more for example than
anything else.
If the first two patches are accepted, don't close the bug and I will (time
permitting) post patches for the remaining instances.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
