https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #17 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2012-03-26 14:51:07 PDT ---
The Coverty scan is reporting a couple of problems in the ua3g dissector; here
are the "missing break" problems:
~~~
2150 case 0x02: /* Timer Form */
2151 {
2152 call_timer = 1;
2153 }
2154 case 0x00: /* Set Current Time/Call Timer */
2155 case 0x01: /* Set Current Time */
~~~
I'm guessing from the code after this that it IS intentional that the code
falls through.
The other case is:
~~~
1968 case 0x06: /* Ringing */
[...]
1994 case 0x02: /* Group Listening */
1995 case 0x03: /* On Hook Dial */
1996 case 0x04: /* Handsfree */
1997 case 0x05: /* Announce Loudspeaker */
~~~
I think that the Ringing case is missing a break.
If you can confirm those two are correct I can check in a fix (or you can
provide a patch if you prefer).
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
