https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874
Ryan Doyle <ryan@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7902|0 |1
is obsolete| |
Attachment #7904|0 |1
is obsolete| |
Attachment #7944| |review_for_checkin?
Flags| |
--- Comment #4 from Ryan Doyle <ryan@xxxxxxxxxxxx> 2012-03-04 02:47:43 PST ---
Created attachment 7944
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7944
Updated patch for inclusion
Thanks for the review so far
I've uploaded a new patch for review which obsoletes the existing two (is this
the preferred way or would you prefer patch sets?).
I've changed all instances proto_tree_add_item to use the ENC_* constants.
Regarding the Clang warnings, I've changed most of the decoding routines to
return void as the returned offset is not used again. I've still elected to
increment the offset after it has passed through the dissecting routines purely
for consistency sake. I did not have any warnings compiling this using GCC
4.6.2.
Regarding the use of proto_tree_add_int/float it seems like I needed to do this
to dissect non-contiguous bytes in the packet but keep the values stored under
the same tree (see comment at line 928 of packet-pcp.c).
Depending on the "valfmt type", the 4 bytes stored after the instance (line 912
of packet-pcp.c) is either the value _or_ a pointer to further in the packet of
another data structure which contains the value.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
