Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 6426] Added execute parameters decoder to MySQL dissector

Date: Tue, 18 Oct 2011 18:13:13 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6426

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #3 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-10-18 18:13:11 PDT ---
Some comments:

1) mysql_dissect_exec_null() doesn't need an ugly hack to avoid unused
parameters warnings: use _U_ instead.

2) This code:

     conn_data= se_alloc(sizeof(mysql_conn_data_t));
     [...]
     conn_data->stmts= g_hash_table_new(g_int_hash, g_int_equal);

leaks memory.  Since the contents of the hash table are also se_alloc'd, it's
not a huge amount of memory, but still...  This patch is removing the one place
where those hash tables are (might be--if we happen to see a close or quit)
destroyed.  Can this be rewritten to use se_trees?

3) hf_mysql_exec_field_string should use (presumably) use ENC_ASCII|ENC_NA.  Or
maybe one of the other string encodings.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.