https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6373
--- Comment #7 from Yaniv Kaul <mykaul@xxxxxxxxx> 2011-09-25 08:45:04 PDT ---
(In reply to comment #3)
> (From update of attachment 7072 [details])
> Hi,
>
> a Quick and small review...
>
> 1) Attach a sample of SPICE Protocol (for test and regression...)
> 2) Use ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN for encoding attribut of
> proto_tree_add_item (no TRUE / FALSE)
> 3) Remove DGBX function (use expert_info ?)
> 4) Attach your change in diff format (see
> http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html )
I hope all comments above were addressed, please review.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
