https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6153
--- Comment #11 from Asmita <adeenesh@xxxxxxxxx> 2011-09-19 01:20:12 PDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Created an attachment (id=7042)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7042) [details]
[details]
> > csg.dll plugin code for csg2 r6
> > I can find check_col is being used in several plugins in same svn version.
> > If it's completely deprecated then which alternative we can use for this!
> > Please review the code and please let me know if it still require to be added
> > as a dissector instead of plugin.
>
> In trunk(the development tree) check_col is not used in any plugin, chcek_col
> is
> deprecated as it's not needed any more as the check is preformed inside the
> function calls e.g. the check can be removed.
>
> Yes we prefer it as a built in dissector.
>
> It should not be a heuristic dissector, the GTP dissection should be made
> by packet-gtp.c use the dissector table for CDR:s in packet-gtp.c or is there a
> compelling reason not to?
>
> Could the radius dissection be done by the radius dissector or the value
> strings
> imported from packet-radius.c?
>
> hf names should start with hf_csg I think, randomly picked example.
> -hf_qualified_refund_unit filter name csg.qualified.refund.unit
> +hf_csg_qualified_refund_unit filter name csg.qualified.refund.unit
>
> What's with
> + proto_csg_ft = proto_register_protocol("CSG FT Protocol",
> + "CSG FT",
> + "csg-ft");
> That seems to not be used any more should all related code including hf vars be
> removed?
>
> Regards
> Anders
Thanks Anders,
I'm removing FT protocol.
Actually I tried to decode packets with packet-gtp.c also. This file (code) is
using some ports
#define GTPv0_PORT 3386
#define GTPv1C_PORT 2123
#define GTPv1U_PORT 2152
I have a query here , the packet I used to decode was using different port
number, so it could not be decoded as a GTP packet. Rather it was decoded as
UDP packet. This is reason I coded it as a plugin.
Thanks
Asmita
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
