https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1123
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6429| |review_for_checkin?
Flag| |
--- Comment #15 from Michael Mann <mmann78@xxxxxxxxxxxx> 2011-05-30 19:49:58 PDT ---
Created an attachment (id=6429)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6429)
UATification of ESP
UATification of ESP SA keys. Some notes:
1. Trimmed a lot of fat removing the code that parsed (and reparsed) ESP SA
keys, since UATs can take care of all that.
2. There was no validation on the src/dest, so that was carried through (ie
there is still no validation of src/dest fields)
3. Formatting of the source was a little off, so I attempted to fix the
functions I needed to deal with. I know that's frowned upon, but the braces
were such that I couldn't tell if/else blocks to understand the code. If
somebody wanted to run an indent program on the file, that would be
appreciated.
4. I could use some assistance in testing the changes as I have a limited
understanding of ESP (but the UAT stuff is fairly straightforward)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
