https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794
--- Comment #28 from Michael Mann <mmann78@xxxxxxxxxxxx> 2011-05-26 07:29:26 PDT ---
(In reply to comment #0)
> 5) PROTABBREV itself is a questionable name, (e.g., it contains a period).
Are PROTABBREV's not allowed to have a period in them? Should that be added to
the script to check? Right now there are 2 "protocol groupings" (along with a
few other various dissectors) with the following behavior:
1. (zbee protocols) - All display filter names are prefixed with zbee.* and the
PROTABBREV of each protocol is zbee.XXX. So the display filter are always
prefixed by PROTABBREV
2. (scsi protocols) - All display filter names are prefixed with scsi.*, but
the PROTABBREV is scsi_XXX. Here, display filter is not prefixed by PROTABBREV
(because of the ./_ difference)
Which is correct? Should all PROTABBREV be changed to zbee_*, and the display
filters to match? If so these are probably patches unto the themselves. If a
period is acceptable in PROTABBREV, then I can make a few 1 line changes to the
scsi protocols and update the perl script to be more accomodating of
PROTABBREVs with periods in them. Those 1 line changes would then just be part
of whatever my next "patch grouping" is.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
