https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5749
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #16 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-05-25 19:23:20 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > I'd still like to see most of the new add_text()'s turn into add_item()s (or
> > other filterable things). (Fixing the old ones would be a bonus, of course.)
> > That being said, I won't reject the patch in case another developer doesn't
> > feel as strongly as I do.
>
> Is "won't reject" the same as accept, or do you want more add_items()s for the
> accept? I was going to leave that to the cleanup Joakim mentioned in comment
> #11. To me, publishing the parsing is much more important then the filtering,
> so I just wanted to get it out there.
It meant I didn't check it in but wasn't going to mark it as
review_for_checkin- in case another developer would check it in.
But, I see your point and am all for incremental progress--so I went ahead and
checked in your patch. Thanks for the contribution--I hope I didn't frustrate
you too much!
(I'd still welcome some cleanup of this dissector!)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
