https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1671
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5430| |review_for_checkin?
Flag| |
--- Comment #8 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-11-05 15:06:25 PDT ---
Created an attachment (id=5430)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5430)
Handle invalid chars in filenames, truncate if too long and handle duplicates.
This patch resolves the problems as seen with exporting the http objects from
the attached capture file. Namely, it will:
-> Replace the reserved characters defined at
http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx with %XX% ...
where XX is the hexadecimal representation of the character.
-> Limit the filename to 255 characters maximum.
-> Handle duplicate filenames (up to 10) by either appending "(#)" if the
filename is short enough to handle the expansion, or replace the last 3
characters of the filename with "(#)" if it can't expand anymore due to the 255
max filename limit. Here '#' represents a digit from 1-9.
-> To address Guy's concerns about the error message not being very good, I
enabled the error reporting so in the event we still encounter some filename
that can't be saved, a error dialog box will appear that contains a more
informative error message.
Since I'm still getting comfortable with gtk and glib and considering I did not
write the original export objects functionality, I thought it would be better
to post the patch here so others could try it out and comment on it first
before I commit it. I guess if I don't hear anything about it for a few days,
I'll go ahead and commit it. Thanks.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
