https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5305|review_for_checkin? |
Flag| |
Attachment #5305|0 |1
is obsolete| |
Attachment #5405| |review_for_checkin?
Flag| |
--- Comment #14 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-11-01 14:14:38 PDT ---
Created an attachment (id=5405)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5405)
Use g_utf16_to_utf8(), but save filter for possible reuse.
Like the previous patch, this patch replaces utf_16to8() with
g_utf16_to_utf8(), but this one will save the filter for potential reuse as
this appears to be the desired functionality despite the difference in behavior
with other platforms.
I didn't see the need to save two separate filters, dfilter_open_str and
dfilter_merge_str, so I combined them into a single dfilter_str.
Also, I didn't see the need to switch from utf_8to16() to g_utf8_to_utf16() for
such short-lived strings, so I left them alone.
Because of these last two choices I made, I am opting not to check in the patch
right away, but to allow other developers to review it first in case my choices
are not acceptable.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
