https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2695
Gerald Combs <gerald@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4721| |review_for_checkin?
Flag| |
--- Comment #2 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2010-06-01 11:01:22 PDT ---
Created an attachment (id=4721)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4721)
Updated WiMAXMACPHY dissector
The dissector has a lot (over 200) combinations of tvb_get_* + proto_tree_add_*
which could be replaced with a single proto_tree_add_item. This doesn't do a
lot of harm but it makes the code more verbose. Also, a lot of hfinfo fields
don't match their formats, e.g. FT_BYTES must now be BASE_NONE.
Attached is an updated packet-wimaxmacphy.c which replaces the tvb_get_ptr +
proto_tree_add_bytes pairs with proto_tree_add_item. It also fixes a lot of the
hfinfo issues.
The dissector should handle encapsulations seen on the wire. In the case of
ethernet encapsulation you might be able to generate packets using Scapy
(http://www.secdev.org/projects/scapy/). Since there's no specific UDP port you
could add a port preference defaulting to 0.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
