https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4757
--- Comment #4 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-05-12 11:12:25 EDT ---
Several additional (minor) comments:
1. Please change the "" to NULL in the "blurb" (the field before the HFILL)
for all the hf[] entries.
+ FT_UINT8, BASE_DEC, NULL, 0x0, "", HFILL }
==>
+ FT_UINT8, BASE_DEC, NULL, 0x0, NULL, HFILL }
2. If the following includes are not needed, please remove them.
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
3. The patch has a property change on epan\dissectors
deleting and then adding *.exe.
I'm not sure what that's about since it's not obvious
that there's any difference. Please just remove any such
(using an editor) when submitting a patch.
Property changes on: epan\dissectors
___________________________________________________________________
Modified: svn:ignore
- *.exe
*.idb
*.ilk
*.lib
...
+ *.exe
*.idb
*.ilk
*.la
*.lib
*.lo
*.marks
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
