Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 4703] IETF TRILL Dissector

Date: Thu, 22 Apr 2010 12:42:16 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4703

David Bond <david.bond@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4560|review_for_checkin?         |
               Flag|                            |
   Attachment #4560|0                           |1
        is obsolete|                            |
   Attachment #4566|                            |review_for_checkin?
               Flag|                            |

--- Comment #6 from David Bond <david.bond@xxxxxxxxxxx> 2010-04-22 12:42:14 PDT ---
Created an attachment (id=4566)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4566)
An updated SVN patch file for TRILL

I have attached an update SVN patch file that I believe addresses your
concerns. 

One Question
"4. Just do a col_set_str(...,COL_PROTOCOL,...) at the beginning iso a
col_clear."

I have deleted the col_clear but as you can see on line 145 that is where I do
the col_set_str. I did this since TRILL encapsulates Ethernet data and I
thought it was logical to still have it show up as TRILL. Therefore we append
to the end of the COL_INFO after the eth dissector has been called. Is this
consistent with what has been done in the past? Should I also set the
COL_INFO/COL_PROTOCOL at the beginning in case we reach an exception?

Thanks,
David

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.