https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934
Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4207|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #11 from Stig Bjørlykke <stig@xxxxxxxxxxxxx> 2010-01-27 14:42:59 PST ---
(From update of attachment 4207)
1. It does not compile because of several uninitialized variables.
2. The use of tvb_get_ptr() should be eliminated, please use appropriate
proto_tree_add_* functions.
3. We have functions to print Ethernet addresses, look in epan/to_str.c
4. You do not need to include comments from the examples in README.developer.
5. CRC handling should be moved to epan/crc/
6. The file heading is not correct.
7. You have a lot of unused hf_ entries, check with tools/checkhf.pl
8. Try use a proper proto_tree_add_ function instead of proto_tree_add_text.
9. Use functions instead of using goto inside a switch statement.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
