https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4299
--- Comment #4 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2009-12-06 13:25:11 PST ---
* The patch contains a definition of a new ARP hardware type for SocketCAN.
Where does this value come from? it's not officially assigned
(http://www.iana.org/assignments/arp-parameters). If it is commonly used, we
can still use it in Wireshark, but it's still good to put a reference to where
it is defined.
* The license header should include:
* Wireshark - Network traffic analyzer
* By Gerald Combs <gerald@xxxxxxxxxxxxx>
* Copyright 1998 Gerald Combs
* The #include <linux;/can.h> isn't going to work on non-Linux platforms.
Since Wireshark runs on Windows and all types of Unix (including MacOS X), it
will fail to even compile with that include there. Users may want to analyze
capture files with SocketCAN traffic on non-Linux platforms as well, so we
can't simply put a conditional clause on that include. The same probably goes
for #include <bits/sockaddr.h>. I don't recognize that as a standard include
file. If the license permits, you can copy the values you need from those
files into the dissector file or find them in standard locations. Make sure
you need values from these header files first of course.
* The rest looks OK, though I haven't had a chance to compile and test it since
my primary development machine isn't Linux.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
