ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 4215] fuzz testing reports possible dissector bug: SMB

Date: Wed, 2 Dec 2009 00:22:04 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4215

--- Comment #2 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2009-12-02 00:21:56 PST ---
I don't have time to finish looking into this right now, so here is what I
found so far:

(In revision 31147) Line 8453 is:

    DISSECTOR_ASSERT(sip);

The lines around it are:

    si = (smb_info_t *)pinfo->private_data;
    DISSECTOR_ASSERT(si);
    sip = si->sip;
    DISSECTOR_ASSERT(sip);
    nti=sip->extra_info;

There are three instances of pinfo->private_data = si; ...

.. on line 7075 in function dissect_session_setup_andx_request():

    if (cmd != 0xff) {     /* there is an andX command */
        if (andxoffset < offset)
            THROW(ReportedBoundsError);
        pinfo->private_data = si;
        dissect_smb_command(tvb, pinfo, andxoffset, smb_tree, cmd, FALSE);
    }

.. on line 7210 in function dissect_session_setup_andx_response():

    if (cmd != 0xff) {     /* there is an andX command */
        if (andxoffset < offset)
            THROW(ReportedBoundsError);
        pinfo->private_data = si;
        dissect_smb_command(tvb, pinfo, andxoffset, smb_tree, cmd, FALSE);
    }

.. on line 17126 in function dissect_smb():

    pinfo->private_data = si;

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.