ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 3948] New: expert info clean up

Date: Wed, 26 Aug 2009 07:42:30 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948

           Summary: expert info clean up
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: dgautheron@xxxxxxxx



didier gautheron <dgautheron@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3574|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=3574)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3574)
expert info fix memory leaks and code clean up

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,

- Remove unused code, using G_TYPE_POINTER rather than G_TYPE_STRING would save
a lot of memory but it needs more work than I'm willing to do.

- Don't save Group in procedure entries, we don't use it.

- Minor memory leak in filter.

- remove memory leak with expert_data->packet_num.

- remove a big memory leak with gdk_color_to_string in expert_dlg.

TODO:
I think that with cf_retap_packet expert_data->pitem is always NULL, the code
could be remove.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.