https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3900
--- Comment #4 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-08-19 06:05:15 PDT ---
You must take into account protocol errors. Hence what to do with this:
+ switch( data & 0x7c )
and with this
+ switch ( data & 0x03 )
+ {
+ case 1:
+ value->OFF = TRUE;
+ break;
+ case 2:
+ value->ON = TRUE;
+ break;
+ }
in this case if ((data & 0x03) == 0) || (data & 0x03) == 3)) ?
Always provide a default case; makes compilers happy.
Also can you test this: /* Todo: not tested .. */
No need to sprinkle your name in the sourcecode, you'll be named in the header
and in the commit comment.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
