Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 3776] Add A support to packet-gsm_abis_ip.c

Date: Mon, 27 Jul 2009 00:53:43 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3776





--- Comment #3 from Harald Welte <laforge@xxxxxxxxxxxx>  2009-07-27 00:53:41 PDT ---
hi zecke.

Thanks for the patches, they make a lot of sense to me.

However, one comment/improvement: rather than using tvb_get_guint8() and then
left-shifting, tvb_get_ntohs() should probably be used for the length in the
IPA dissector.

Otherwise, regarding the wireshark maintainers: I fully support this patch
series.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.