https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3732
--- Comment #10 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2009-07-25 00:27:56 PDT ---
Hi,
- Don't use global variables unless absolutly neccessary
e,g (+static int isdn_all_address_tmp = -1;)
make them guin16:s and fetch the value with
guint16 tvb_get_ntohs(tvbuff_t*, gint offset); or
guint16 tvb_get_letohs(tvbuff_t*, gint offset);
- Don't mix the declaration of hf_ variables with other declarations.
- Prefix all hf variables like hf_v52_ to keep with the style of other
dissectors
All the cases like
col_append_str(pinfo->cinfo, COL_INFO, " | ");
col_append_fstr(pinfo->cinfo, COL_INFO, "ref: %u",
bcc_all_address_tmp);
could be changed to
col_append_fstr(pinfo->cinfo, COL_INFO, " | ref: %u",
bcc_all_address_tmp);
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
