Wireshark-bugs: [Wireshark-bugs] [Bug 2533] EBCDIC display for TN3270 packet

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 3 Jun 2009 12:03:42 -0700 (PDT)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2533





--- Comment #5 from hoganrobert <robert@xxxxxxxxxxxxxxx>  2009-06-03 12:03:39 PDT ---
(In reply to comment #4)
> This patch needs more cleaning before it can become part of the main
> repository.

And then some! It has only just graduated from naive-draft-from-spec to
kind-of-works prototype.

> - Indentations must be consistent (don't mix tabs and spaces)
> - Drop not required includes.
> - For telnet.c don't put in a parameter in comments in telnet_add_text()
> - "Remove memleaks", a must do item.
> - Remove the C++ style comments, non-portable
> - Drop the (Tor based?) preferences, they're not used

No problem.

> - Fix the header fields
Not sure what you're referring to here. Can you clarify?



-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.