https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3399
Summary: [PATCH] add SIP URI PARTS dissection to packet-sip.c
Product: Wireshark
Version: SVN
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Medium
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: andreas.heise@xxxxxxxxxxxxx
CC: anders.broman@xxxxxxxxxxxx
Andreas Heise <andreas.heise@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2922| |review_for_checkin?
Flag| |
Created an attachment (id=2922)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2922)
diff patch for packet-sip.c against SVN R27985
Build Information:
wireshark 1.1.4-NextiraOne-005 (SVN Rev unknown)
Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled with GTK+ 2.16.0, with GLib 2.20.0, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Apr 8 2009), with
AirPcap.
Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4,
Gcrypt 1.4.4, without AirPcap.
Built using Microsoft Visual C++ 9.0 build 30729
--
A small patch to improve display and filter handling for the SIP URI.
The patch also fix a problem for the contact URI parsing.
FUZZ test was applied, attached is the diff patch against SVN R27985
and also a sample SIP capture with lot of different PAI / PPI headers
to give an example.
diff patch contains:
fix: 'contact_item_end_offset' was wrong if URI is not in '<>'
in this case '\r' was displayed due to error in trim '\r\n'
improve: 'dissect_sip_uri' function to provide uri_user offsets
improve: 'dissect_sip_uri' function to provide uri_host offsets
improve: 'dissect_sip_uri' function to provide uri_host_port offsets
add: subtree 'Request-URI' to 'Request-Line'
add: item 'Request-URI User Part' to 'Request-URI'
add: item 'Request-URI Host Part' to 'Request-URI'
add: item 'Request-URI Host Port' to 'Request-URI'
change: item 'SIP to address' to subtree 'SIP to address'
add: item 'SIP to address User Part' to 'SIP to address'
add: item 'SIP to address Host Part' to 'SIP to address'
add: item 'SIP to address Host Port' to 'SIP to address'
change: item 'SIP from address' to subtree 'SIP from address'
add: item 'SIP from address User Part' to 'SIP from address'
add: item 'SIP from address Host Part' to 'SIP from address'
add: item 'SIP from address Host Port' to 'SIP from address'
add: subtree 'P-Asserted-Identity' header to 'hdrtree'
add: item 'SIP Display Info' to 'P-Asserted-Identity'
add: subtree 'SIP PAI Address' to 'P-Asserted-Identity'
add: item 'SIP PAI User Part' to 'SIP PAI Address'
add: item 'SIP PAI Host Part' to 'SIP PAI Address'
add: item 'SIP PAI Host Port' to 'SIP PAI Address'
add: subtree 'P-Preferred-Identity' header to 'hdrtree'
add: item 'SIP Display Info' to 'P-Preferred-Identity'
add: subtree 'SIP PPI Address' to 'P-Preferred-Identity'
add: item 'SIP PPI User Part' to 'SIP PPI Address'
add: item 'SIP PPI Host Part' to 'SIP PPI Address'
add: item 'SIP PPI Host Port' to 'SIP PPI Address'
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
