https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170
Florian Forster <wireshark.org@xxxxxxxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2640|review_for_checkin? |
Flag| |
Attachment #2640 is|0 |1
obsolete| |
Attachment #2661| |review_for_checkin?
Flag| |
--- Comment #10 from Florian Forster <wireshark.org@xxxxxxxxxxxxxxxxxxx> 2009-01-09 13:09:09 PDT ---
Created an attachment (id=2661)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2661)
Revised patch against revision 27204.
Hi,
thanks for your feedback :)
(In reply to comment #9)
> Three things:
> 1. proto_register_collectd() doesn't need to be protected with initialized,
> it's only called once.
Okay, removed that.
> 2. hf[] entries where 'name' and 'blurb' are the same (like
> hf_collectd_data_time has "Timestamp" twice) can have 'blurb' set to NULL.
What's the advantage of using NULL there? For me, reading the code is easier
when all entries in that array are filled in the same manner, especially since
I'm not that familiar with the API.
> 3. Can you make the UDP port a preference? The collected man page says it can
> be configured differently from the 25826 default. Have a look at packet-dis.c
> in trunk on how to do that (Note: packet-dis.c code in 1.0.x is incorrect!)
Okay, did it as it's done in `packet-dis.c' (current SVN, of course).
I've also added a little `stats_tree' thingy, that for now shows the number of
`VALUE' sections received. I've two questions regarding that:
1) These statistics will probably only be interesting for a small number of
Wireshark's users. I think it'd be appropriate to enable/disable the menu-
entry in the configuration. However, I didn't not find a way to un-register
a stats_tree. How do you usually handle such situations? Put the statistics
stuff into a plugin?
2) In the posted sample PCAP file, there are 660 ``values'' and the file covers
90 seconds. I therefore expect the `rate' displayed in the stats_tree to be
about 660 / 90 = 7.33. Instead, it's 0.007333, that's 1/1000th of what I
expected. Is that intended?
Regards,
-octo
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
