Wireshark-bugs: [Wireshark-bugs] [Bug 3164] Dissector for QoS Marking attributes in BGP UPDATE messages

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 2 Jan 2009 09:44:59 -0800 (PST)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3164


Thomas M. Knoll <knoll@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2608|review_for_checkin?         |
               Flag|                            |
Attachment #2608 is|0                           |1
           obsolete|                            |
   Attachment #2613|                            |review_for_checkin?
               Flag|                            |




--- Comment #7 from Thomas M. Knoll <knoll@xxxxxxxxxxxxxxxxxxx>  2009-01-02 09:44:59 PDT ---
Created an attachment (id=2613)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2613)
rereworked dissector patch for BGP QoS Marking attributes in UPDATE messages

I added a clear distinction between regular and extended length now by means of
separate string arrays (bgpext_com_type[] and bgpext_com8_type[]). Presumably,
this is the consistent solution to the overlap.
As far as the type field structure is concerned, I consider the IANA and
transitive bit as beeing part of the type number assignment and would not
really like to separate this from the remaining 6 bits in the coding. All
numbers in the registry as well as in http://tools.ietf.org/html/rfc4360 are
stated as byte values. Although I am not completely sure, I am somewhat
inclined to say that transitive and non-transitive versions of an ext.
community are not mandatorily ment to follow the same naming as well as the
same internal structure.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.