Wireshark-bugs: [Wireshark-bugs] [Bug 2727] New packet dissector for RTPS & RTPS2

From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 1 Aug 2008 12:25:05 -0700 (PDT)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2727


Anders Broman <anders.broman@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anders.broman@xxxxxxxxxxxx




--- Comment #2 from Anders Broman <anders.broman@xxxxxxxxxxxx>  2008-08-01 12:25:04 PDT ---
Hi,
Found a couple of problems:
nmake -f makefile.nmake checkapi
Error: Found prohibited APIs in packet-rtps.c: strcpy,strncpy,strncat
Error: Found prohibited APIs in packet-rtps2.c: strcpy,strncpy,strcat,strncat

proto_tree_add_item_hiden()
Is depreciated example fix:
    proto_item * ti, *hidden_item;
    proto_tree * guid_tree;

    /* The numeric value (used for searches) */
    hidden_item = proto_tree_add_item(tree,
                        hf_prefix,
                        tvb,
                        offset,
                        12,
                        FALSE);
        PROTO_ITEM_SET_HIDDEN(hidden_item);

I think you should retain the original copyright notice just add your own.
Regards
Anders


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.