Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 2688] Mojito Protocol Dissestor Plugin

Date: Fri, 25 Jul 2008 19:47:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2688





--- Comment #14 from Travis Dawson <travis.dawson@xxxxxxxxxx>  2008-07-25 19:47:55 PDT ---
It was not actually embedded in the fucntion, just an indenting issue my editor
likes to do at times. Its fixed now so you  can better see the fact that it is
in fact two separate functions (not one embedded in the other.)

(In reply to comment #13)
> Created an attachment (id=2066)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2066) [details]
> Source Code
> 
> Source code is fixed to address indenting issues. 
> 

(In reply to comment #12)
> Regarding:
> 
>         /* The actual work */
>                 static void
>                 dissect_mojito(tvbuff_t *tvb, packet_info *pinfo, proto_tree
> *tree)
> 
> IIRC not all compilers support declaring functions inside of functions.  Anyway
> it forces you another level of indentation which just makes the code harder to
> read.  (This would be easy enough for someone to correct when checking the file
> in--I don't have time to finish reviewing it now but I wanted to mention this
> since I noticed it.)
> 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.