https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2690
Summary: packet-pppoe.c has wrong types for PADG, PADC and PADQ
Product: Wireshark
Version: 1.0.1
Platform: All
OS/Version: Linux
Status: NEW
Severity: Normal
Priority: Low
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: pdice@xxxxxxxxx
Build Information:
Version 1.0.99 (SVN Rev 25669)
Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled with GTK+ 2.10.11, with GLib 2.12.11, with libpcap 0.9.8, with libz
1.2.3, with POSIX capabilities (Linux), with libpcre 7.0, without SMI, without
ADNS, without Lua, with GnuTLS 1.4.5, with Gcrypt 1.2.4, with MIT Kerberos,
without PortAudio, without AirPcap.
Running on Linux 2.6.21-1.3194.fc7, with libpcap version 0.9.8.
Built using gcc 4.1.2 20070502 (Red Hat 4.1.2-12).
Wireshark is Open Source Software released under the GNU General Public
License.
Check the man page and http://www.wireshark.org for more information.
--
The #defines for PADG, PADC, and PADQ are incorrect and these packets are
showing up as unknown.
In packet-pppoe.c:
#define PPPOE_CODE_PADG 0x10
#define PPPOE_CODE_PADC 0x11
#define PPPOE_CODE_PADQ 0x12
from the draft:
IANA has assigned the following PPPoE Code fields as noted in [3]:
Code PPPoE Packet Name Description Reference
-------- ----------------------------- ----------------- ---------
10 0x0a PADG, Session-Grant See the reference [RFC4938]
11 0x0b PADC, Session-Credit Response See the reference [RFC4938]
12 0x0c PADQ, Quality See the reference [RFC4938]
I would be happy to fix this bug as I would like to enhance the current support
for rfc4938 and rfc4938bis to include filtering and inband credit grant
decoding.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
