Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 1520] PDML Export sets empty "value" attribute for ip. fra

Date: Wed, 25 Jun 2008 06:35:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1520


Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.r.mathieson@googlemai
                   |                            |l.com




--- Comment #4 from Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>  2008-06-25 06:35:54 PDT ---
The problem seems to be that we don't show the "value" fields for FT_NONE
fields, which I think I agree with.

I changed the type of sip.msg_hdr to be an FT_STRING, which as well as fixing
the PDML output makes it more useful as a filterable field (revision 25602).

I wasn't so sure about changing the type of ip.fragments.  I'll attach the
patch for setting it to FT_BYTES, the only problem is that it will then display
the bytes (until it truncates them) in the root node (and it would be tricky to
eliminate this because it would need to be done in a common function -
process_reassembled_data()).  I think the output looks OK (it will truncate and
list the fragments before the line gets too long), but I'll mark the patch for
review for a while to see if anyone cares.




-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.