Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 2091] X25 reassembly when presenting out of order packets

Date: Thu, 24 Apr 2008 05:21:37 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091


Gerhard Olsson <gerhard.nospam@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1739|                            |review_for_checkin?
               Flag|                            |




--- Comment #5 from Gerhard Olsson <gerhard.nospam@xxxxxxxxx>  2008-04-24 05:21:14 GMT ---
Created an attachment (id=1739)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1739)
Comments on applied patch

Compilation did not work since the depending bug 2090 is not applied.
Actually, the bug can be applied without 2090 (not too bad) (but that should be
done) or with a different spin to 2090 (only setting ONE_MORE_SEGMENT not
changing from void to int, will update 2090 later)

The changed patch is basically the following:

-   return  tcp_dissect_pdus(tvb, pinfo, tree, xot_desegment,
-                            get_xot_pdu_len_mult_int(pinfo, tvb, 0, 1),
-                            get_xot_pdu_len_mult, dissect_xot_mult);
+    tcp_dissect_pdus(tvb, pinfo, tree, xot_desegment,
+                             get_xot_pdu_len_mult_int(pinfo, tvb, 0, 1),
+                             get_xot_pdu_len_mult, 
+                                                        dissect_xot_mult);
+    return tvb_length(tvb);

This will not work (?) when there are several XOT sequences in the last TCP
segment. (I have though not found a test case, but this goes against the
documented use of heuristic dissectors).
I will submit a new patch that implements the changes in 2090 in XOT.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.