ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 2491] New: Expert Info Composite dialog triggers Gtk-CRITI

Date: Tue, 22 Apr 2008 07:32:08 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2491

           Summary: Expert Info Composite dialog triggers Gtk-CRITICAL **:
                    gtk_label_set_text: assertion
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: jyoung@xxxxxxx


Build Information:
Version 1.0.99 (SVN Rev 25146)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.8.3, with GLib 2.8.1, with libpcap 0.9.2, with libz 1.2.3,
with POSIX capabilities (Linux), without libpcre, without SMI, without ADNS,
without Lua, with GnuTLS 1.2.5, with Gcrypt 1.2.1, without Kerberos, with
PortAudio V19-devel, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.13-15.18-default, with libpcap version 0.9.2.

Built using gcc 4.0.2 20050901 (prerelease) (SUSE Linux).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
Hello,

The GTK error message cited below displays only when the newer Expert Info
Composite dialog window is used.

> (lt-wireshark:26024): Gtk-CRITICAL **: gtk_label_set_text: assertion `GTK_IS_LABEL (label)' failed

The attached patch simply confirms that the variable etd->label is non-NULL
before attempting to use it.

Background:

There are currently two different Expert Info dialogs that can be opened.

1) older dialog, from the menu Analyze -> Expert Info
2) newer dialog, from the menu Analyze -> Expert Info Composite

The newer Expert Info Composite dialog (#2) can also be opened by clicking on
the recently added circular "expert info indicator" widget located at the
bottom left corner of the Wireshark main window (really a very nice feature add
Ulf!).

Both Expert Info dialogs use functionality implemented within the "expert" TAP
and consequently follow some common codepaths.  But each dialog uses its own
instance of the etd structure.  The variable etd->label is non-NULL when using
the older Expert Info dialog but it is NULL within the context of the newer
Expert Info Composite dialog.

The etd->label is used with the older Expert Info dialog, but is not used with
the newer Expert Info Composite dialog.

With the older Expert Info dialog, the etd->label variable is used alternately
to display transient status messages such as "Please wait..." or more generally
to give the user the total count of the various expert info severity message
events:

  "Errors: 0 Warnings: 0 Notes: 0 Chats: 0"

A similar --- but not identical --- count is presented in the tabs of newer
Expert Info Composite dialog.   While the functionality of the newer Expert
Info Composite dialog is generally "better", it does not currently replace all
of the
information or functionality of the older expert info dialog.

Specifically the older Expert Info dialog gives the user absolute totals of the
four expert message severity events, whereas the newer Expert Info Composite
dialog gives the user a "composite" count of the various message severity
events on the seperate notebook tab labels.   

FWIW: 

A small feature patch I hope to submit in a few days would augment the Expert
Info Composite notebook tab labels to include the absolute error_events,
warn_events, note_events, and chat_events.  Each tab will display the severity
counts as %u/%u where the left hand value is the composite message type count
and the right hand value is the total event count (as currently displayed in
the older Expert Info dialog).


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.