http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2263
--- Comment #10 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2008-04-08 17:02:00 GMT ---
Most of us are still somewhat recovering from SharkFest'08 (you weren't there?
then you've missed something) and there's a lot of code to go through.
Looking at the code I can see:
packet-sercosiii*.c missing GPL statement and $Id$ line.
packet-sercosiii*.c has moduleinfo.h, which it doesn't need.
"proto_tree* errortree _U_ = NULL;" what does this do?
Please use
----8<----
#define OPEN_IDN 1
...
case OPEN_IDN:
----8<----
i.s.o.
----8<----
case 1: /* Open IDN */
----8<----
Same for
----8<----
if(mdt_svc_idn[devno] == 1009)
----8<----
We've got no clue what 1009 means. A #define would make it so much more
readable
You use malloc and free for some purpose. We prefer using se_ or ep_ functions
for that. Please refer to README.malloc in doc/
That's it so far. Now I have to eat first.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
